Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progressive loading for schema validator output #3322

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Progressive loading for schema validator output #3322

merged 9 commits into from
Feb 11, 2025

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 5, 2025

This avoids loading the BIDS validator output for schema validator datasets, instead loading this once the validation drop down is clicked. For many datasets this avoids several megabytes of data transfer and potentially expensive API requests until this is actually needed.

A related bug fix is included to more accurately disable creating snapshots when the schema validator output contains errors or the draft has no author values provided.

See #3313

@nellh nellh requested a review from thinknoack February 5, 2025 23:04
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.30189% with 99 lines in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (769d876) to head (c1325b2).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...src/scripts/validation/validation-results-query.ts 56.81% 19 Missing ⚠️
...enneuro-server/src/graphql/resolvers/validation.ts 0.00% 19 Missing ⚠️
...-app/src/scripts/validation/validation-results.tsx 48.38% 16 Missing ⚠️
...nneuro-app/src/scripts/dataset/routes/snapshot.tsx 0.00% 13 Missing ⚠️
...penneuro-app/src/scripts/validation/validation.tsx 79.31% 12 Missing ⚠️
...ro-components/src/search-page/SearchResultItem.tsx 26.66% 11 Missing ⚠️
packages/openneuro-server/src/graphql/schema.ts 0.00% 5 Missing ⚠️
...enneuro-app/src/scripts/uploader/upload-issues.tsx 0.00% 2 Missing ⚠️
...nneuro-app/src/scripts/dataset/draft-container.tsx 0.00% 1 Missing ⚠️
...pp/src/scripts/dataset/routes/tab-routes-draft.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
- Coverage   47.72%   47.21%   -0.51%     
==========================================
  Files         590      591       +1     
  Lines       37666    37768     +102     
  Branches     1272     1243      -29     
==========================================
- Hits        17976    17834     -142     
- Misses      19503    19747     +244     
  Partials      187      187

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thinknoack
thinknoack approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@thinknoack thinknoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing the app locally looks good. I see loading animations for both draft and snapshots. Code looks good, tests pass, and no lint issues.

@nellh
Merge pull request #3323 from OpenNeuroOrg/fix/search-validation-icon
c1325b2 
fix(app): Display correct search validation status for schema validator datasets
@nellh nellh merged commit b5d94f0 into master Feb 11, 2025
14 of 15 checks passed
@nellh nellh deleted the feat/progressive-loading-validation branch February 11, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinknoack thinknoack thinknoack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nellh @thinknoack